Realtime Publish #23

tiholic · 2020-07-28T16:25:55Z

Publishing realtime messages either as name and data or as a Message object or List<Message>

//publish name and data
await channel.publish(name: "event1", data: "Yesterday is history, tomorrow is a mystery, but today is a gift");
await channel.publish(name: "event1", data: {"Yesterday": "history", "tomorrow": "mystery", "today": "gift"});
await channel.publish(name: "event1", data: [{"Yesterday": {"is": "history"}, "tomorrow": {"mystery": true}, "day_after": null}, "today", "gift"]);

//publish single message
await channel.publish(message: ably.Message()..name = "event1"..data = {"today": "gift"});

//publish multiple messages
await channel.publish(messages: [
  ably.Message()..name="event1"..data = {"yesterday": "history"},
  ably.Message()..name="event1"..data = {"tomorrow": "mystery"},
  ably.Message()..name="event1"..data = {"today": "gift"}
]);

README.md

example/lib/main.dart

lib/src/impl/realtime/channels.dart

android/src/main/java/io/ably/flutter/plugin/AblyMessageCodec.java

1. AblyMessage string representation for better logging while debugging 2. readValueAsJsonElement made static so can be used elsewhere 3. Type conversion fixes for Message[] and data

QuintinWillison

I seem to have been sat on this one for days, accumulating comments. Finally getting round to completing it. Few minor tweaks please.

android/src/main/java/io/ably/flutter/plugin/AblyMethodCallHandler.java

example/test_harness/listen.js

ios/Classes/AblyFlutterPlugin.m

README.md

android/src/main/java/io/ably/flutter/plugin/AblyFlutterMessage.java

android/src/main/java/io/ably/flutter/plugin/AblyMessageCodec.java

1. var -> const 2. code formatting using `prettier` playground: https://prettier.io/playground/

1. spaces over tabs as preferred by default java formatter 2. remove extra line at EOF, in dart

#23 (comment)

tiholic requested review from QuintinWillison, mattheworiordan and paddybyers July 28, 2020 16:26

tiholic force-pushed the feature/realtime-message-subscription branch from da53d26 to 7b4db0b Compare July 30, 2020 06:41

tiholic force-pushed the feature/realtime-publish branch from 6e3750a to 41a97e1 Compare July 30, 2020 07:28

tiholic force-pushed the feature/realtime-message-subscription branch from f40547b to 1624991 Compare August 3, 2020 10:35

tiholic force-pushed the feature/realtime-publish branch from 9178040 to 9949795 Compare August 3, 2020 10:44

tiholic requested a review from zoechi August 3, 2020 11:27

zoechi suggested changes Aug 3, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

example/lib/main.dart Show resolved Hide resolved

lib/src/impl/realtime/channels.dart Outdated Show resolved Hide resolved

tiholic force-pushed the feature/realtime-message-subscription branch from 1624991 to eb93cb5 Compare August 4, 2020 20:07

tiholic force-pushed the feature/realtime-publish branch from 9949795 to c727e99 Compare August 4, 2020 20:19

zoechi approved these changes Aug 5, 2020

View reviewed changes

QuintinWillison reviewed Aug 10, 2020

View reviewed changes

android/src/main/java/io/ably/flutter/plugin/AblyMessageCodec.java Outdated Show resolved Hide resolved

tiholic force-pushed the feature/realtime-message-subscription branch from 515167b to d582121 Compare August 12, 2020 15:09

Base automatically changed from feature/realtime-message-subscription to main August 12, 2020 15:11

tiholic added 15 commits August 12, 2020 20:43

codegen for Message

a0134ef

new platform method publishRealtimeChannelMessage

f17cc23

encode and decode channel message on dart and android side respectively

ef23555

method call implemented

972136c

dart: fix for message publish

1cf4471

test harness for testing message subscription form example app

91df489

1. AblyMessage string representation for better logging while debugging 2. readValueAsJsonElement made static so can be used elsewhere 3. Type conversion fixes for Message[] and data

listen.js in test_harness for testing listening to channel messages

95725af

enhance example for publishing messages

2d8004c

simplify publish by sending an array of messages to platform, always

5f7bdd6

suppressing connectionId and timestamp from sending to platform side

4a00da0

iOS: publish implementation

9b2f1ab

show connection state in example app

1fe654b

README update

184b385

README update with example

4676df8

optimize imports

2b851c9

tiholic added 5 commits August 12, 2020 20:43

making README non-distracting

23156fd

horizontal overflow in example

4d9f59c

horizontal overflow in example

be10e56

syntactic sugar | using collection-if

edf8aa5

making gson variable final

176d8c1

tiholic force-pushed the feature/realtime-publish branch from 59ff55b to 176d8c1 Compare August 12, 2020 15:13

QuintinWillison suggested changes Aug 13, 2020

View reviewed changes

tiholic added 7 commits August 18, 2020 09:59

marking appropriate variables as final

a2540e4

improve test-harness code

0504025

1. var -> const 2. code formatting using `prettier` playground: https://prettier.io/playground/

format README.md

e8eab0f

improve formatting of generated code

24d2877

1. spaces over tabs as preferred by default java formatter 2. remove extra line at EOF, in dart

android code-format

052467d

fix method call formatting

f265e07

#23 (comment)

improve code formatting on iOS source

eff54ca

QuintinWillison approved these changes Aug 18, 2020

View reviewed changes

tiholic merged commit 66cb9d3 into main Aug 18, 2020

tiholic added a commit that referenced this pull request Aug 18, 2020

fix method call formatting

3f0757e

#23 (comment)

tiholic deleted the feature/realtime-publish branch August 18, 2020 07:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Realtime Publish #23

Realtime Publish #23

tiholic commented Jul 28, 2020 •

edited

Loading

QuintinWillison left a comment

Realtime Publish #23

Realtime Publish #23

Conversation

tiholic commented Jul 28, 2020 • edited Loading

QuintinWillison left a comment

Choose a reason for hiding this comment

tiholic commented Jul 28, 2020 •

edited

Loading