Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drive test example #32

Merged
merged 5 commits into from
Aug 18, 2020
Merged

Drive test example #32

merged 5 commits into from
Aug 18, 2020

Conversation

zoechi
Copy link
Contributor

@zoechi zoechi commented Aug 5, 2020

Because flutter drive tests need to be a flutter application project I created such a project as sub-project in the test_integration directory.
I'm not sure if this is a good name.
I didn't want to name it test_driver because that is normally used to contain driver tests directly.
There is not really a rule that would limit what the name could be.

The test_driver.sh batch file executes all driver tests in that sub-project.

test_integration/README.md contains further information.

Copy link
Contributor

@tiholic tiholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like using FlutterDriver gives better control over integration tests. I feel we can move forward with this.

Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty well self-contained so I've not done a deep review on this one. If you could make these tweaks done though please.

@zoechi zoechi merged commit 921e079 into main Aug 18, 2020
@zoechi zoechi deleted the drive_test_example branch August 18, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants