Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS podspec tweaks #46

Merged
merged 9 commits into from
Sep 24, 2020
Merged

iOS podspec tweaks #46

merged 9 commits into from
Sep 24, 2020

Conversation

QuintinWillison
Copy link
Contributor

@QuintinWillison QuintinWillison commented Sep 15, 2020

At 72c575a this branch sorts out failing flutter run for iOS in my test project locally. The test project's pubspec.yaml looks like this (with the majority of comments removed for brevity):

name: ably_flutter_from_github
description: A new Flutter project.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1
environment:
  sdk: ">=2.7.0 <3.0.0"
dependencies:
  flutter:
    sdk: flutter
  ably_flutter_plugin:
    git:
      url: https://github.com/ably/ably-flutter.git
      ref: feature/ios-podspec-20200915
  cupertino_icons: ^0.1.3
dev_dependencies:
  flutter_test:
    sdk: flutter
flutter:
  uses-material-design: true

Quintin Willison added 5 commits September 15, 2020 13:28
It was generating the following warning from pod spec lint:
WARN  | description: The description is equal to the summary.
It was generating the following warning from pod spec lint:
WARN  | license: Missing license type.
It conflicted with s.ios.deployment_target
Not sure if this is required or not but feels like the right thing to do.
@QuintinWillison QuintinWillison self-assigned this Sep 15, 2020
@QuintinWillison QuintinWillison marked this pull request as ready for review September 18, 2020 14:57
Copy link
Contributor

@tiholic tiholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works like charm, now, on iOS!

@QuintinWillison QuintinWillison merged commit 3c9a78e into main Sep 24, 2020
@QuintinWillison QuintinWillison deleted the feature/ios-podspec-20200915 branch September 24, 2020 08:07
@tiholic tiholic linked an issue Nov 2, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Getting error after add this plugin to project
2 participants