-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel history & Paginated Result API for Rest #48
Channel history & Paginated Result API for Rest #48
Conversation
d67dae9
to
4522117
Compare
494cf25
to
5d4fd98
Compare
4522117
to
a79ae46
Compare
9ad0c11
to
7bb9496
Compare
a79ae46
to
36e8507
Compare
7bb9496
to
89d43b1
Compare
36e8507
to
b59621b
Compare
fcb3928
to
ad0f349
Compare
16813d0
to
ca8ea08
Compare
5df822d
to
b3c6097
Compare
75abddd
to
b3c6097
Compare
storage, retrieval and returning to platform
…om platform back to dart
history can be queried based on the provided params
bc479d9
to
56ab554
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not looked at this pull request at the level of depth I would like to, but I'm short on time and we need to get a release out.
None of the comments I've made need block this pull request from landing so, @tiholic, please don't add any more commits to the underlying branch. For each of my comments, could you please either:
- Create an issue to defer the work to fix it until later.
- Create a pull request to fix it now if you have time (in which case that pull request's underlying branch should branch from the latest branch you've been working to allow the entire backlog to fold down correctly)
And then add a comment to the conversation to point towards which approach you'll take. I'll resolve the conversations later.
@@ -164,3 +170,21 @@ extern NSString *const TxMessage_data; | |||
extern NSString *const TxMessage_name; | |||
extern NSString *const TxMessage_extras; | |||
@end | |||
|
|||
@interface TxPaginatedResult : NSObject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These @interface
declarations and the corresponding @implementation
blocks do nothing. I would prefer that we remove them as the inference is that they add value, but they don't.
@@ -364,6 +365,31 @@ class _MyAppState extends State<MyApp> { | |||
child: Text('Publish'), | |||
); | |||
|
|||
Widget getRestChannelHistory() => FlatButton( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, I think this code could benefit from some commentary. If nothing else for each of the three cases in the if
statement. It's a little bit opaque on a brief scan. I'm finding myself puzzling over why _restHistory
could be null
, but also why you use ?
/??
at the start but a direct comparison to == null
later.
This is meant to be example code so we cannot have too much commentary. Many developers taking a look will be time poor so need their hands held.
Conflicts. 🤔 I'm resolving them now. |
# Conflicts: # README.md
Rest#Channel#Channel#history
will returnPaginatedResult
.PaginatedResult supports methods:
hasNext()
,isLast()
,async next()
andasync first()
as per the docs#TG