-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Realtime Channel history #52
Realtime Channel history #52
Conversation
c78ced1
to
13ddca8
Compare
de9f1ec
to
b0d7d5b
Compare
13ddca8
to
fd96591
Compare
aa9e2b5
to
ef4a0f9
Compare
b53a4dc
to
b3c6097
Compare
ef4a0f9
to
5b0caa9
Compare
3007dea
to
27f732f
Compare
5b0caa9
to
368fe06
Compare
27f732f
to
000915a
Compare
368fe06
to
6fafb3f
Compare
5422182
to
bc5b7ea
Compare
7fff784
to
1b994a9
Compare
bc5b7ea
to
8c17472
Compare
1b994a9
to
a8bc0a6
Compare
1. Generating new type constants for realtimeHistoryParams 2. removing `RestHistoryArguments` and using `TransportKeys` so they can be used globally by all call sites invoking platform method with Key-Value payload.
8c17472
to
d90cc6a
Compare
print('failed to get history:: $e :: ${e.errorInfo}'); | ||
} | ||
}, | ||
onLongPress: (_rest == null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Is this behaviour obvious? Maybe I don't fully understand the context (I've not loaded the app in a while, least not for this branch), but I would usually expect a long-press to first present a menu or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QuintinWillison long press is not intuitive, I had a plan to enhance this, but primary focus was not on example.
await Future.delayed(const Duration(seconds: 2)); | ||
|
||
final time1 = DateTime.now(); | ||
//TODO(tiholic) iOS fails without this delay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static const String realtimePublishWithAuthCallback = | ||
'realtimePublishWithAuthCallback'; | ||
// TODO(tiholic) handle realtimeHistoryWithAuthCallback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realtime#Channel#Channel#history will return PaginatedResult.