Rename Package to remove the _plugin suffix #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuintinWillison
force-pushed
the
feature/rename-package
branch
from
b955f26 to
f528a96
Compare
QuintinWillison
changed the base branch from
main
to
feature/conform-workflow-trigger
tiholic
approved these changes
Feb 17, 2021
| @@ -1,4 +1,4 @@ | |||
| import 'package:ably_flutter_plugin/src/spec/spec.dart'; | |||
| import 'package:ably_flutter/src/spec/spec.dart'; | |||
There was a problem hiding this comment.
Not sure how I missed this earlier, but linting should have picked up prefer_relative_imports
There was a problem hiding this comment.
This can be ignored in this PR and I can take it up later. I'll be checking regularly for any linting pointers for every commit.
There was a problem hiding this comment.
Also, in upcoming PR's we are capturing these lint pointers in workflows: https://github.com/ably/ably-flutter/blob/b917e0e86fdd5d575b3ab2b57d0646580d00992f/.github/workflows/flutter_integration.yaml
There was a problem hiding this comment.
I just checked, it is fixed in another branch already: https://github.com/ably/ably-flutter/blob/feature/realtime-presence-get-history/lib/src/spec/common.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll land this pull request before #89.
As discussed in Slack, I'm also going to create a private fork of this repository so we can push a discontinuation to the current package. Clearly that falls outside of the scope of this pull request.