Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac support #817

Merged
merged 33 commits into from
Dec 20, 2018
Merged

Mac support #817

merged 33 commits into from
Dec 20, 2018

Conversation

ricardopereira
Copy link
Contributor

@ricardopereira ricardopereira commented Nov 29, 2018

Installation Guide

⚠️ Push Notifications are unavailable in macOS.

CocoaPods

pod 'Ably', :git => 'https://github.com/ably/ably-ios.git', :branch => 'mac-support'

Carthage

github "ably/ably-ios" "mac-support"

Demo

screenshot 2018-11-30 at 10 04 55

Demo available here.

Most important changes

Mostly project configurations has been changed.

Travis file has been updated:

  • iOS 9, 10, 11, 12 is being tested
  • macOS 10.14 is being tested

New targets and scheme:

  • Ably has been renamed to Ably-iOS
  • Ably-macOS has been added (minimum deployment target is 10.10 Yosemite)
  • Ably-tvOS has been added (but not ready because of one dependency that hasn't support for tvOS).

Dependencies:

  • New ULID version because the macOS support was broken.
  • New msgpack-objective-C from ably-forks/msgpack-objective-C

Reference #460

 - This needs to be reviewed.
 - This change because iOS/macOS force you to use https.
…encies (private dependencies) to Carthage.

 - Remove usage of CocoaPods in all test targets.
…g 2000 messages to sandbox sometimes takes more than 20 seconds. Let's stick with 1 min.
/<module-includes>:1:1: Umbrella header for module 'Ably' does not include header 'ARTNSString+ARTUtil.h'
/<module-includes>:1:1: Umbrella header for module 'Ably' does not include header 'ARTNSArray+ARTFunctional.h'
/<module-includes>:1:1: Umbrella header for module 'Ably' does not include header 'ARTOSReachability.h'
/<module-includes>:1:1: Umbrella header for module 'Ably' does not include header 'ARTNSDictionary+ARTDictionaryUtil.h'
/<module-includes>:1:1: Umbrella header for module 'Ably' does not include header 'ARTGCD.h'
@ricardopereira
Copy link
Contributor Author

@mattheworiordan @paddybyers Sorry for this huge PR but it's mainly project configuration that I was struggling to get it right. Now it is future proof. I mean, we can add tvOS support quite easily.

Maybe we need to consider changing the name of the repo to ably-cocoa instead of ably-ios like other library devs companies do: https://github.com/getsentry/sentry-cocoa, https://github.com/realm/realm-cocoa, ...

@paddybyers
Copy link
Member

I've not looked through in detail.

What needs to happen before we can merge the mac support branch?

Maybe we need to consider changing the name of the repo to ably-cocoa instead of ably-ios like other library devs companies do

I'd be ok with that in principle if we set up a repo redirect so it's transparent to users of the existing git url.
I think iOS is still the primary use-case and is probably the most natural name. But if we do rename it,

@ricardopereira
Copy link
Contributor Author

What needs to happen before we can merge the mac support branch?

@paddybyers Nothing in particular. This is ready to land in develop branch.

I'd be ok with that in principle if we set up a repo redirect so it's transparent to users of the existing git url.

Yes indeed. I never done that. Most likely things will brake for users that are using old versions if we rename the repository to ably-cocoa. Need to do some investigation.

@mattheworiordan
Copy link
Member

mattheworiordan commented Dec 2, 2018 via email

@ricardopereira
Copy link
Contributor Author

@mattheworiordan macOS and tvOS (#821) are ready. Should I launch a release with those (v1.1.3)?
Please review the PR's because I can't merge without at least one approval.

Ricardo would you mind looking into whether there’s a way to rename libraries?

We just need to rename the repository. GitHub redirects will handle old versions.

@ricardopereira ricardopereira merged commit f788095 into develop Dec 20, 2018
@ricardopereira ricardopereira deleted the mac-support branch December 20, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants