-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac support #817
Mac support #817
Conversation
- This needs to be reviewed.
- This change because iOS/macOS force you to use https.
- macOS 10.10 Yosemite
…encies (private dependencies) to Carthage. - Remove usage of CocoaPods in all test targets.
…g 2000 messages to sandbox sometimes takes more than 20 seconds. Let's stick with 1 min.
/<module-includes>:1:1: Umbrella header for module 'Ably' does not include header 'ARTNSString+ARTUtil.h' /<module-includes>:1:1: Umbrella header for module 'Ably' does not include header 'ARTNSArray+ARTFunctional.h' /<module-includes>:1:1: Umbrella header for module 'Ably' does not include header 'ARTOSReachability.h' /<module-includes>:1:1: Umbrella header for module 'Ably' does not include header 'ARTNSDictionary+ARTDictionaryUtil.h' /<module-includes>:1:1: Umbrella header for module 'Ably' does not include header 'ARTGCD.h'
@mattheworiordan @paddybyers Sorry for this huge PR but it's mainly project configuration that I was struggling to get it right. Now it is future proof. I mean, we can add Maybe we need to consider changing the name of the repo to |
I've not looked through in detail. What needs to happen before we can merge the mac support branch?
I'd be ok with that in principle if we set up a repo redirect so it's transparent to users of the existing git url. |
@paddybyers Nothing in particular. This is ready to land in
Yes indeed. I never done that. Most likely things will brake for users that are using old versions if we rename the repository to |
Thanks Ricardo.
I think we should not only land it on develop, but bump the minor version and document tvOS and macOS support in the readme & changeling. We also need to update the www.ably.io/download <http://www.ably.io/download> page to include details on those OS’ being supported.
In regards to renaming, I think that is sensible. Github offers redirects now, so that will be done seemlessly. In regards to the package though and where it’s published, I don’t know how that works. Ricardo would you mind looking into whether there’s a way to rename libraries?
We should probably defer the rename until the 1.1 release, which is around the corner (aiming for 2nd week of Dec).
… On 30 Nov 2018, at 09:53, Ricardo Pereira ***@***.*** ***@***.***>> wrote:
What needs to happen before we can merge the mac support branch?
@paddybyers <https://github.com/paddybyers> Nothing in particular. This is ready to land in develop branch.
I'd be ok with that in principle if we set up a repo redirect so it's transparent to users of the existing git url.
Yes indeed. I never done that. Most likely things will brake for users that are using old versions if we rename the repository to ably-cocoa. Need to do some investigation.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#817 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACrDUt-90EOqqT65oZc6atvBnt0OWlNks5u0UZhgaJpZM4Y5iuL>.
|
@mattheworiordan macOS and tvOS (#821) are ready. Should I launch a release with those (v1.1.3)?
We just need to rename the repository. GitHub redirects will handle old versions. |
Installation Guide
CocoaPods
pod 'Ably', :git => 'https://github.com/ably/ably-ios.git', :branch => 'mac-support'
Carthage
github "ably/ably-ios" "mac-support"
Demo
Demo available here.
Most important changes
Mostly project configurations has been changed.
Travis file has been updated:
New targets and scheme:
Ably
has been renamed toAbly-iOS
Ably-macOS
has been added (minimum deployment target is 10.10 Yosemite)Ably-tvOS
has been added (but not ready because of one dependency that hasn't support fortvOS
).Dependencies:
ULID
version because the macOS support was broken.msgpack-objective-C
from ably-forks/msgpack-objective-CReference #460