Add until attach functionality to Presence & Channel #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| private static final String KEY_UNTIL_ATTACH = "untilAttach"; | ||
| private static final String KEY_FROM_SERIAL = "from_serial"; |
There was a problem hiding this comment.
FYI @gokhanbarisaker we changed all query string params from under_score case to camelCase a little while ago but did not roll it out everywhere, hence this comment...
gokhanbarisaker
force-pushed
the
channel-untilattach
branch
from
ac99c0b to
634c188
Compare
| BodyHandler<Message> bodyHandler = MessageSerializer.getMessageResponseHandler(options); | ||
| return new PaginatedQuery<Message>(ably.http, basePath + "/history", HttpUtils.defaultAcceptHeaders(ably.options.useBinaryProtocol), params, bodyHandler).get(); | ||
| return new PaginatedQuery<>(ably.http, basePath + "/history", HttpUtils.defaultAcceptHeaders(ably.options.useBinaryProtocol), params, bodyHandler).get(); |
There was a problem hiding this comment.
This is I am sure my lack of knowledge of Java syntax here, but why did we drop the Message here?
There was a problem hiding this comment.
It is automatically using the generic passed down with BodyHandler. Therefore, we don't need to explicitly specify the generic again.
|
This looks ok to me now. @mattheworiordan ? |
|
LGTM |
mattheworiordan
added a commit
that referenced
this pull request
Mar 2, 2016
Add until attach functionality to Presence & Channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #36