Defaults: Generate environment fallbacks #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per `RSC15g` introduced in ably/docs#965 Signed-off-by: Lewis Marshall <[email protected]>
SimonWoolf
approved these changes
Sep 14, 2020
This was referenced Sep 17, 2020
sacOO7
reviewed
Oct 6, 2020
sacOO7
reviewed
Oct 6, 2020
sacOO7
reviewed
Oct 6, 2020
sacOO7
reviewed
Oct 6, 2020
|
The above comments were added as a part of ably/ably-java#618 review. Observations are based on spec for implementing fallbacks (ably/docs#965). i.e. some of the observations might not be valid if I missed out on other details from the spec :p |
sacOO7
reviewed
Oct 9, 2020
sacOO7
reviewed
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per
RSC15gintroduced in ably/docs#965.