Fixes issues #40 and #42 #44
Conversation
jdavid
commented
Apr 24, 2017
jdavid
commented
- fromEncoded, fromEncodedArray
- HttpRequest & HttpRetry timeouts
|
Nice, any idea on the failures? |
|
Fixed. We already saw errors like this one with ably-python. Apparently the server does not like the |
| @@ -269,7 +269,7 @@ public function testPublishConnectionKey() { | |||
| $msg = new Message(); | |||
| $msg->name = 'delegatedMsg'; | |||
| $msg->data = 'test payload'; | |||
| $msg->connectionKey = 'fake!realtime_key'; | |||
| $msg->connectionKey = 'fake.realtime_key'; | |||
There was a problem hiding this comment.
What error were you getting with the !. This is expected to fail anyway no?
There was a problem hiding this comment.
timeout error
you can see the error in the build for the master branch
https://travis-ci.org/ably/ably-php/jobs/218008466#L426
There was a problem hiding this comment.
we had the same issue with ably-python
it got fixed in this commit
ably/ably-python@e4078f2
but I understand there is still an issue server side, it should not timeout imho
|
One small question, but otherwise this looks good |
|
Can you do a version bump and I can arrange a release soon |
|
what version should it be? (current version is 1.0.0) |
|
Just a patch bump, so 1.0.1 |
