Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client libraries to generate fallback hosts from custom environment #818

Closed
QuintinWillison opened this issue Feb 21, 2020 · 0 comments · Fixed by #965
Closed

Client libraries to generate fallback hosts from custom environment #818

QuintinWillison opened this issue Feb 21, 2020 · 0 comments · Fixed by #965
Assignees
Labels
content-request A request for new content, as opposed to changing/fixing existing content

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Feb 21, 2020

This enhancement will automatically use fallback hosts, deterministically derived from the supplied environment, when they've not been specified explicitly.

It will solve the problem whereby customers ship their app built against our client library, seeing that it works with basic testing, but don't realise that it will quickly stop working when things go wrong with the primary host.

See the internal issue which proposes this enhancement.

┆Issue is synchronized with this Jira Task by Unito

@QuintinWillison QuintinWillison added content-request A request for new content, as opposed to changing/fixing existing content important labels Feb 21, 2020
@QuintinWillison QuintinWillison self-assigned this Feb 21, 2020
mattheworiordan added a commit to ably/ably-ruby that referenced this issue Feb 21, 2020
When environment is set in the client SDKs, we can now rely on default fallback hosts as follows.

Fallbacks are ENV-[a-e]-fallback.ably-realtime.com. For example:

ENV-a-fallback.ably-realtime.com
ENV-b-fallback.ably-realtime.com
ENV-c-fallback.ably-realtime.com
ENV-d-fallback.ably-realtime.com
ENV-e-fallback.ably-realtime.com

Note that this change:

- It breaks a lot of tests against sandbox that assumed no fallback hosts would be used
- We need to ensure that custom hosts or custom ports result do not use default environment fallback hosts.  We should only use when only the custom environment is set
- Some spec updates are needed in the spec relating to the use of fallback hosts

See related issue ably/docs#818 (no spec yet exists)
@mattheworiordan mattheworiordan changed the title Client libraries to generate fallback hosts from environment Client libraries to generate fallback hosts from custom environment Feb 21, 2020
TheSmartnik pushed a commit to ably/ably-ruby that referenced this issue Nov 30, 2020
When environment is set in the client SDKs, we can now rely on default fallback hosts as follows.

Fallbacks are ENV-[a-e]-fallback.ably-realtime.com. For example:

ENV-a-fallback.ably-realtime.com
ENV-b-fallback.ably-realtime.com
ENV-c-fallback.ably-realtime.com
ENV-d-fallback.ably-realtime.com
ENV-e-fallback.ably-realtime.com

Note that this change:

- It breaks a lot of tests against sandbox that assumed no fallback hosts would be used
- We need to ensure that custom hosts or custom ports result do not use default environment fallback hosts.  We should only use when only the custom environment is set
- Some spec updates are needed in the spec relating to the use of fallback hosts

See related issue ably/docs#818 (no spec yet exists)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-request A request for new content, as opposed to changing/fixing existing content
Development

Successfully merging a pull request may close this issue.

2 participants