Track line numbers in copyright files #13 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
From aboutcode-org/typecode#20 Reported-by: Pierre Tardy <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>
And remove v prefix from fallback version Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
* This is handy for windows to have the same path as linux Signed-off-by: Chin Yeung Li <[email protected]>
Create junction from Scripts to bin
Signed-off-by: Jono Yang <[email protected]>
Check for deps in local thirdparty directory #31
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Create copyright statement from holder information Signed-off-by: Jono Yang <[email protected]>
* This is used for the case where we are starting off a project and have not yet generated requirements files Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Replace all references to `tmp` with `venv` Signed-off-by: Jono Yang <[email protected]>
* Add --init option to configure.bat
* Update help text in configure and configure.bat
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Update README.rst Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
* Update README.rst with instructions for post-initialization usage Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This was not used anywhere. Also make minor updates to docstrings. Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This was an unused duplicate of: debian_inspector.copyright.CatchAllParagraph Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This adds support for tracking line number when processing copyright files. The approach is to only support this for copyright files and keep a mapping of start/end line numbers by field name at the paragraph level. This way existing fields do not need modifications and the core code update is when paragraphs are created which is limited to a single place. There is also a new deb822 module replacing the email parser to parse copyright files keep track of line numbers. Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
* Replace references to scancode-toolkit repo with links to the skeleton repo
* Remove --python option from configure.bat
Signed-off-by: Jono Yang <[email protected]>
Update skeleton
Signed-off-by: Jono Yang <[email protected]>
Add README.rst to etc/scripts/
This is allowed in deb822 and also in copyright processing. There a duplicated field will be made unique by renaming it by adding a suffix with an incremented number. Also add Paragraph get_field_line_numbers() methods Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
When a field first line (the line with the field name) was empty, we were Signed-off-by: Philippe Ombredanne <[email protected]>
- Rename ParagraphMixin to BaseParagraph - Restore from_dict() method - use fields rather than header fields as name - improve and fix merging of contiguous paragraphs - Recover parsing some mostly valid dep5-like copyright files Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
|
This is now all green and working fine in SCTK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tracking of line numbers in Debian copyright files for #13
This is to support license line number reporting in
aboutcode-org/scancode-toolkit#2643
It also adds a few extra minor updates: