Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive email detection #2810

Open
pombredanne opened this issue Jan 25, 2022 · 3 comments
Open

False positive email detection #2810

pombredanne opened this issue Jan 25, 2022 · 3 comments
Labels
bug email and url scan

Comments

@pombredanne
Copy link
Member

In a binary ARM build of libiconv (the attached text file contains a strings dump of the culprit section) this junk email was found
[email protected]

6H.txt
pombredanne added a commit that referenced this issue Feb 14, 2022
@pombredanne
Add domain check to email detection
fd81c3d 
By checking that we have a proper public suffix domain, we avoid many
junk emails.

Reference: #2810
Signed-off-by: Philippe Ombredanne <[email protected]>
@chaitanya710
Copy link

Hello. I performed an email scan and it did not detect a false positive. Also when I modified that to a valid domain like gmail, it detected as a valid result.

@pombredanne
Copy link
Member Author

Hello. I performed an email scan and it did not detect a false positive. Also when I modified that to a valid domain like gmail, it detected as a valid result.

Thanks! This confirms that fd81c3d is a proper fix. I can now close this.

@AyanSinhaMahapatra
Copy link
Member

AyanSinhaMahapatra commented Mar 31, 2022 •
edited
Loading

We still detect a cc0 license here btw, which shouldn't be detected. #2878 #2403

@pombredanne pombredanne reopened this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug email and url scan
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pombredanne @AyanSinhaMahapatra @chaitanya710