Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScientiaMobile commercial license not detected #3162

Closed
vargenau opened this issue Nov 28, 2022 · 4 comments
Closed

ScientiaMobile commercial license not detected #3162

vargenau opened this issue Nov 28, 2022 · 4 comments
Labels
bug new and improved data Priority: high

Comments

@vargenau
Copy link
Contributor

Description

Download Haproxy at: http://www.haproxy.org/download/2.6/src/snapshot/haproxy-ss-20221026.tar.gz

File contrib/wurfl/wurfl/wurfl.h contains the following header:

/*
 * InFuze C API - HAPROXY Dummy library version of include
 *
 * Copyright (c) ScientiaMobile, Inc.
 * http://www.scientiamobile.com
 *
 * This software package is the property of ScientiaMobile Inc. and is licensed
 * commercially according to a contract between the Licensee and ScientiaMobile Inc. (Licensor).
 * If you represent the Licensee, please refer to the licensing agreement which has been signed
 * between the two parties. If you do not represent the Licensee, you are not authorized to use
 * this software in any way.
 *
 */

When running ScanCode, this commercial license is not detected.

SPDX result is:

# File

FileName: ./haproxy-ss-20221026/contrib/wurfl/wurfl/wurfl.h
SPDXID: SPDXRef-138
FileChecksum: SHA1: a4272af065e6f2201c0cc431cc72da9372723419
LicenseConcluded: NOASSERTION
LicenseInfoInFile: NONE
FileCopyrightText: <text>Copyright (c) ScientiaMobile, Inc. http://www.scientiamobile.com
</text>

How To Reproduce

scancode -c -l -i --license-text --spdx-tv haproxy_ss_20221026.spdx haproxy-ss-20221026

System configuration

  • What OS are you running on? Linux Ubuntu 22.10
  • What version of scancode-toolkit was used to generate the scan file?
scancode --version
ScanCode version: 31.2.1
ScanCode Output Format version: 2.0.0
SPDX License list version: 3.17
  • What installation method was used to install/run scancode? pip
@vargenau vargenau added the bug label Nov 28, 2022
@vargenau vargenau changed the title ScientiaMobile commercial license to detected ScientiaMobile commercial license not detected Nov 28, 2022
@pombredanne pombredanne mentioned this issue Nov 28, 2022
Closed
@pombredanne
Copy link
Member

@vargenau Thank you for the report! 🙇
I entered this haproxy/haproxy#1948 upstream and we will be adding rules to correctly detect this weirdness.

pombredanne added a commit that referenced this issue Nov 28, 2022
@pombredanne
Add commercial license detection rules #3162
097298d 
Reference: #3162
Reference: haproxy/haproxy#1948
Reported-by: Marc-Etienne Vargenau <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne
Copy link
Member

This 097298d is fixing this

@pombredanne pombredanne mentioned this issue Nov 29, 2022
Merged
4 tasks
pombredanne added a commit that referenced this issue Nov 29, 2022
@pombredanne
Add commercial license detection rules #3162
aa061c2 
Reference: #3162
Reference: haproxy/haproxy#1948
Reported-by: Marc-Etienne Vargenau <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne
Copy link
Member

@vargenau this has been kindly fixed upstream by @wtarreau in haproxy/haproxy#1948 and together with the fixes mentioned earlier, this is ready to be closed now. This is also ready in the latest ScanCode toolkit 32rc release

@pombredanne
Copy link
Member

Actually there is likely still a pending issue upstream as explained haproxy/haproxy#1948 (comment) and
here haproxy/haproxy#1948 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug new and improved data Priority: high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vargenau @pombredanne