-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_dump_rule_file depends on OS filename sorting #3581
Comments
Fixes aboutcode-org#3581. Signed-off-by: Jeff Licquia <[email protected]>
Thanks! I wonder if there is something special with Debian 12 and the file system encoding? @AyanSinhaMahapatra we likely want to add Debian 12 as a CI target. |
I'm not sure; my guess was that it was simply unsorted by default, since the results from the debugger showed the files being reported in what seemed like a random order. For what it's worth, it's a brand-new install (never upgraded from a previous version of Debian), and here are the mount flags pasted from
|
Fixes #3581. Signed-off-by: Jeff Licquia <[email protected]> Co-authored-by: Jeff Licquia <[email protected]>
@pombredanne yes, we have #2731 open to also have debian in CI |
Description
The test
TestRule.test_dump_rule_file
intests/licensedcode/test_models.py
appears to rely on the native OS to sort directory listings when finding rule files to compare. On my system (Debian 12), this results in the test attempting to compare a rule file for GPL 2.0 to a rule file for the LZMA license, which obviously fails. Sorting the results ofmodels.load_rules()
for each fixes the problem.How To Reproduce
System configuration
** Linux, specifically Debian 12
** The develop branch (specifically, commit 1c4d6be)
** Checkout from GitHub
The text was updated successfully, but these errors were encountered: