setup: Use packaging version <22 #3177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same locking version is used in requirements. If we do not lock, the 22.0 removed Legacy version, see the error: `ImportError: cannot import name 'LegacyVersion' from 'packaging.version'` Signed-off-by: Martin Kojtal <[email protected]>
|
@pombredanne Can you review please? |
|
@0xc0170 Thank you ++ for the PR, we used a different approach to fix this as pinning the |
pombredanne
added a commit
that referenced
this pull request
Dec 21, 2022
Reference: #3177 Reference: #3171 Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
added a commit
that referenced
this pull request
Dec 21, 2022
Reference: #3177 Reference: #3171 Signed-off-by: Philippe Ombredanne <[email protected]>
|
I am pushing a hotfix in this branch https://github.com/nexB/scancode-toolkit/tree/v31.2.2-branch-hotfix as vv31.2.3 |
|
Thanks, I'll restart our tests and if there is any issue I'll get back. It should be all good |
pombredanne
added a commit
that referenced
this pull request
Dec 23, 2022
* Switch to using packvers fork of packaging * Bump pip requirements parser, but it still using packaging. * Bump dparse2 which is using packvers * Pin SPDX tools for cope with breaking APIs * Update release script to build one release wheel for each Python version that each contain a pickle of the License index * Streamline the app build * Bump version and use correct SPDX version Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
added a commit
that referenced
this pull request
Dec 23, 2022
* Switch to using packvers fork of packaging * Bump pip requirements parser, but it still using packaging. * Bump dparse2 which is using packvers * Pin SPDX tools for cope with breaking APIs * Update release script to build one release wheel for each Python version that each contain a pickle of the License index * Streamline the app build * Bump version and use correct SPDX version Signed-off-by: Philippe Ombredanne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same locking version is used in requirements. If we do not lock, the 22.0 removed Legacy version, the error I am seeing:
ImportError: cannot import name 'LegacyVersion' from 'packaging.version'I verified packaging version 22.0 what was breaking there, it really removed LegacyVersion, we should lock to < 22.0.
Requirements (txt files in the root) have the version properly locked (using exact 21 version match), not certain why setup config has different version match. I also wonder why this has not been reported so far, have I missed anything?
See ARMmbed/mbed-os#15357 (we got license check job failing since few days ago).
Tasks
Run tests locally to check for errors.