Vendor attrs to avoid unpickle issues #3179 #3192 #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have vendored attrs only for its use in licensedcode.models. With this, we avoid updates to the attrs library that would make unpickling the license index fail. Reported-by: Soim @soimkim Reference: #3192 Reference: #3179 Signed-off-by: Philippe Ombredanne <[email protected]>
|
Note: this PR is for a hot fix release and not designed to be merged as-is in develop. It will need some backporting and resolution of conflicts, or can be reapplied by hand. |
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This was restored with the introduction of packvers Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
This fixes #3179 and we already have a release out with that.
I've merged develop into this to make this PR merge ready, but there is #3195 btw but it's not crashing the install so we can probably handle that in v32? or do we have to backport that fix too?
some CIs are failing because scancode checkout is taking an hour fsr, probably a fluke?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have vendored attrs only for its use in licensedcode.models. With this, we avoid updates to the attrs library that would make unpickling the license index fail.
Reported-by: Soim @soimkim
Reference: #3192
Reference: #3179
Signed-off-by: Philippe Ombredanne [email protected]
Tasks
Run tests locally to check for errors.