Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license db generation #3197

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Update license db generation #3197

merged 4 commits into from
Jan 16, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jan 11, 2023

Reference: #2738

  • Removes the CLI option --dump-license-data
  • add a new console script scancode-license-data-dump
  • Removes is_builtin attribute from details
  • Removes the text attribute as there already was a license_text displayed so this wasn't necessary

Signed-off-by: Ayan Sinha Mahapatra [email protected]

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

* Removes is_builtin attribute from details
* Removes the text attribute as there already was a license_text
  displayed so this wasn't necessary

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit pickings for your review.
Thanks!

src/licensedcode/license_db.py Outdated Show resolved Hide resolved
src/licensedcode/license_db.py Outdated Show resolved Hide resolved
src/licensedcode/license_db.py Outdated Show resolved Hide resolved
* Removes CLI option `--dump-license-data`
* Adds new console script `scancode-license-data --path PATH`
* Updates CHANGELOG

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pombredanne pombredanne merged commit 0d294bf into develop Jan 16, 2023
@pombredanne pombredanne deleted the fix-license-dump branch January 16, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants