Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing T in date #3203

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Remove trailing T in date #3203

merged 1 commit into from
Jan 18, 2023

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Jan 17, 2023

That's a leftover from a full ISO timestamp

Signed-off-by: Philippe Ombredanne [email protected]

Fixes #0000

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

That's a leftover from a full ISO timestamp

Signed-off-by: Philippe Ombredanne <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra added this to the v32.0 milestone Jan 17, 2023
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've fixed the failing test in #3202 so this is ready to merge.

@pombredanne
Copy link
Member Author

The failing tests is unrelated and fixed in develop. Merging!

@pombredanne pombredanne merged commit ebe35cb into develop Jan 18, 2023
@pombredanne pombredanne deleted the correct-license-dump-date branch January 18, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants