Add new proprietary license detection rule #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ninad Ambade <[email protected]>
4 tasks
Signed-off-by: Ninad Ambade <[email protected]>
Signed-off-by: Ninad Ambade <[email protected]>
Signed-off-by: Ninad Ambade <[email protected]>
Signed-off-by: Ninad Ambade <[email protected]>
|
@AyanSinhaMahapatra Thanks for the feedback on the last PR. As suggested, I added the .LICENSE file and also added more rules from the search appearances in github. Two of the test are failing and it appears to me that it is because of mit.LICENSE file even though I didn't change it in this PR. Do you have an idea about what went wrong here? https://dev.azure.com/nexB/scancode-toolkit/_build/results?buildId=9896&view=logs&jobId=ced651ac-e3ba-569a-0963-de6511468ba5&j=ced651ac-e3ba-569a-0963-de6511468ba5&t=dd42dcb9-b2e2-5e0c-62dc-d6034619d509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3225
Tasks
Run tests locally to check for errors.
Signed-off-by: Ninad Ambade [email protected]