Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license rules #3642

Merged
merged 20 commits into from
Feb 27, 2024
Merged

Update license rules #3642

merged 20 commits into from
Feb 27, 2024

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jan 17, 2024

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

pombredanne and others added 12 commits December 30, 2023 09:51
Signed-off-by: Philippe Ombredanne <[email protected]>
Thanks @DennisClark for adding these.

Reference: #3618
Reported-by: Armijn Hemel @armijnhemel
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3565
Reported-by: @pombredanne
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3613
Reported-by: @fviernau Frank Viernau
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3540
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3515
Reference: #3512
Reported-by: @bennati
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3488
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3491
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
This commit improves a few existing license rules to be more selective
adding either required phrasesz or minimum coverage.

Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #3491
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne and others added 7 commits February 19, 2024 16:07
Signed-off-by: Philippe Ombredanne <[email protected]>
These need to be stricter

Signed-off-by: Philippe Ombredanne <[email protected]>
This is a rare license and should only be detected when there are
significant matches.

Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to merge!

@AyanSinhaMahapatra
Copy link
Member Author

Thanks @pombredanne , merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 66d7166 into develop Feb 27, 2024
33 of 34 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the update-license-rules branch February 27, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants