Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve npm workspace processing #3857

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jul 9, 2024

  • Handle cases where the workspace root package.json has a name
  • Yield correctly dependencies from workspaces
  • Properly populate for_package fields for workspaces
  • Fix a pnpm-lock.yaml parsing bug where we were failing/adding namespaces wrongly

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AyanSinhaMahapatra Looks good!

@AyanSinhaMahapatra
Copy link
Member Author

Thanks @JonoYang , merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit dd675aa into develop Jul 10, 2024
34 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the update-npm-workspace branch July 10, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants