Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python package detection issues #3859 #3869

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix python package detection issues #3859 #3869

merged 1 commit into from
Jul 31, 2024

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jul 24, 2024 •
edited
Loading

Reference: #3859

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the update-pypi-package-detection branch from aa4ec4d to 6600a26 Compare July 26, 2024 17:36
pombredanne
pombredanne approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks

@AyanSinhaMahapatra
Fix python package detection issues #3859
d78f193 
Reference: #3859
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the update-pypi-package-detection branch from 6600a26 to d78f193 Compare July 29, 2024 13:50
@AyanSinhaMahapatra
Copy link
Member Author

Thanks @pombredanne, merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 2b09be1 into develop Jul 31, 2024
34 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the update-pypi-package-detection branch July 31, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

@JonoYang JonoYang Awaiting requested review from JonoYang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyanSinhaMahapatra @pombredanne