Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize Licenses #3897

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Synchronize Licenses #3897

merged 4 commits into from
Aug 22, 2024

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Aug 21, 2024 •
edited
Loading

Synchronizes with SPDX License List 3.25.0, and also adds other licenses added by @DennisClark

This release of the SPDX license list had:

  • 9 new licenses and exceptions
    • 5 were present as licenses
    • 2 were present as rules
    • 2 new license/exception texts added
  • 1 license was deprecated.

Reference: #3896

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@AyanSinhaMahapatra
Add new licenses to LicenseDB
3eddc85 
These were added by @DennisClark

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Support SPDX License List 3.25
fffc98f 
Reference: #3896
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
pombredanne approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good... just a few nits for your review and follow ups
You may want to also double check that we have a rule for the exact text from SPDX, as they are often subtly modified there and other will pick up the modifications afterwards.

src/licensedcode/data/licenses/erlang-otp-linking-exception.LICENSE Show resolved Hide resolved
src/licensedcode/data/licenses/hpnd-netrek.LICENSE Show resolved Hide resolved
DennisClark
DennisClark approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@DennisClark DennisClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the additions and changes look good to me. Nice that we already have the necessary Owners defined.

@AyanSinhaMahapatra
Add and re-qualify license rules
d76977d 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Aug 22, 2024
Open
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the update-spdx-license-list-3.25 branch from 657ab57 to dc8eaa6 Compare August 22, 2024 09:42
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 745ba9c into develop Aug 22, 2024
33 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the update-spdx-license-list-3.25 branch August 22, 2024 11:38
@stefan6419846 stefan6419846 mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisClark DennisClark DennisClark approved these changes

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyanSinhaMahapatra @pombredanne @DennisClark