Fix the pipeline details fetch for URLs with credentials #998 (#1048)

* Fix the pipeline details fetch for URLs with credentials #998 Signed-off-by: tdruez <[email protected]> * Remove the console.log debug statement #998 Signed-off-by: tdruez <[email protected]> --------- Signed-off-by: tdruez <[email protected]>
aboutcode-org · Jan 16, 2024 · 09217dd · 09217dd
1 parent 7f3ad87
commit 09217dd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -34,6 +34,10 @@ v33.0.0 (unreleased)
   project pipeline.
   https://github.com/nexB/scancode.io/issues/997
 
+- Fix an issue where the pipeline details cannot be fetched when using URLs that
+  include credentials such as "user:pass@domain".
+  https://github.com/nexB/scancode.io/issues/998
+
 v32.7.0 (2023-10-25)
 --------------------
 

diff --git a/scanpipe/templates/scanpipe/modals/run_modal.html b/scanpipe/templates/scanpipe/modals/run_modal.html
@@ -5,10 +5,17 @@
     if (modal_id !== "run-detail-modal") return;
 
     let $modal = document.getElementById(modal_id);
-    let run_uuid = event.detail.$button.dataset.uuid;
-    let run_detail_url = `/run/${run_uuid}/`;
     $modal.innerHTML = "";
 
+    let run_uuid = event.detail.$button.dataset.uuid;
+    let run_detail_path = `/run/${run_uuid}/`;
+
+    // Construct the full URL by combining the current origin and the relative path.
+    // It's important to use the URL constructor, as directly providing the relative
+    // path to the `fetch` function may not work correctly, especially for URLs
+    // that include credentials such as "user:[email protected]".
+    let run_detail_url = new URL(run_detail_path, window.location.origin);
+
     fetch(run_detail_url).then(function (response) {
       if (response.ok) {
         return response.text();