Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to submit bugs #122

Open
chinyeungli opened this issue Mar 31, 2021 · 9 comments
Open

Ability to submit bugs #122

chinyeungli opened this issue Mar 31, 2021 · 9 comments

Comments

@chinyeungli
Copy link
Contributor

Ideally, when viewing a file and spot bugs, user can select the texts and submit bugs.

One approach is to auto-generated a github ticket (while the user still needs to use his/her own github ID)

Other possible/potential approaches are welcome to be discussed.

@AyanSinhaMahapatra
Copy link
Member

Using the analyzer to spot issues.

Results file after applying the analyzer post-scan plugin on the Debian copyright files: copyrights-debian-analyzer.json.txt

  1. Spots the license detection issues and classifies them
  2. Groups the license matches in a location together into one issue, with a combined text.
  3. If the same issues appear elsewhere in the scan list them together and show the issue once.

IMHO this could help with the issue review and bug submission process a lot.

Though note that, license-expression suggestions are only preliminary and based on the faulty matches themselves, so they work in only straightforward cases.

@tdruez
Copy link
Contributor

tdruez commented Mar 31, 2021

@AyanSinhaMahapatra could you provide all the steps (with code) on how you run and apply the analyzer?
The link @ https://github.com/nexB/scancode-results-analyzer#documentation is not working by the way.
Also, any reasons for not publishing this tool on pypi? We cannot integrate it in ScanCode.io until then...

@AyanSinhaMahapatra
Copy link
Member

AyanSinhaMahapatra commented Mar 31, 2021

@tdruez Yes, I had requested for the RTD site to be added, as I do not have access to add repos. I do have it set up for my fork - https://scancode-results-analyzer-fork-ayan.readthedocs.io/

Installation and running the plugin works as described here - https://github.com/nexB/scancode-results-analyzer/blob/main/INSTALL.rst

For example, this file was generated by running the following, after installation

scancode -clpieu path/to/copyrights-debian-march31/ --json-pp path/to/copyrights-debian-analyzer.json --is-license-text --license-text --classify --analyze-license-results

No there's no reasons for not publishing on pypi, but @pombredanne and I were still discussing on the details and report format, fixing some issues, so it got delayed. We are working on that, to then integrate with scancode.io

Related tickets are ->

@AyanSinhaMahapatra
Copy link
Member

Btw, aboutcode-org/scancode-analyzer#21 is closed now, scancode-analyzer is available as a pypi package and docs is at https://scancode-analyzer.readthedocs.io/en/latest/

@tdruez
Copy link
Contributor

tdruez commented Apr 9, 2021

@AyanSinhaMahapatra that's great news. I'll start a branch implementing scancode-analyzer as a pipeline (we have several pending tickets on this).

@AyanSinhaMahapatra
Copy link
Member

So this ticket on designing and having a format to review/resolve issues in scancode.io #137 would be needed before that? I can start with integrating analyzer in a pipeline then with your help?

@AyanSinhaMahapatra
Copy link
Member

@pombredanne
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants