Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should support having an input as an image #132

Closed
pombredanne opened this issue Apr 6, 2021 · 3 comments
Closed

We should support having an input as an image #132

pombredanne opened this issue Apr 6, 2021 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@pombredanne
Copy link
Member

VMDK, VDI and QCOW2 are common VM image formats for rootfs (so is squashfs but we already support this).
See aboutcode-org/extractcode#16 as this is the primary dependency.

@pombredanne pombredanne added the enhancement New feature or request label Apr 6, 2021
@pombredanne
Copy link
Member Author

See aboutcode-org/extractcode#20 for some progress

@pombredanne pombredanne added this to the 2021-05 milestone Apr 7, 2021
tdruez added a commit that referenced this issue Jun 1, 2021
tdruez added a commit that referenced this issue Jun 1, 2021
tdruez added a commit that referenced this issue Jun 1, 2021
@tdruez
Copy link
Contributor

tdruez commented Jun 3, 2021

The image extraction works but the extracted structure fails with the rootfs pipeline:

codebase/image.qcow2
codebase/image.qcow2-extract
'NoneType' object has no attribute 'merge'

Traceback:
  File "scancode.io/scanpipe/pipelines/__init__.py", line 96, in execute
    step(self)
  File "scancode.io/scanpipe/pipelines/root_filesystems.py", line 54, in find_root_filesystems
    self.root_filesystems = list(rootfs.RootFs.from_project_codebase(self.project))
  File "scancode.io/scanpipe/pipes/rootfs.py", line 101, in from_project_codebase
    yield RootFs(location=rootfs_location)
  File "<attrs generated init scanpipe.pipes.rootfs.RootFs>", line 4, in __init__
    self.__attrs_post_init__()
  File "scancode.io/scanpipe/pipes/rootfs.py", line 88, in __attrs_post_init__
    self.distro = Distro.from_rootfs(self.location)
  File "scancode.io/lib/python3.9/site-packages/container_inspector/distro.py", line 355, in from_rootfs
    return base_distro.merge(found)

@tdruez
Copy link
Contributor

tdruez commented Jun 10, 2021

Support added and available in https://github.com/nexB/scancode.io/releases/tag/v21.6.10

@tdruez tdruez closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants