-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ABOUT files for code that is patched or vendored #740
Comments
In that example,
What value are we using to map, the
Do we want to create the DiscoveredPackage even if no |
This is correct. If it existed on the From/ side we can decide later what to do
For a start, yes we are mapping on he exact filename. We may extend this later if this is not good enough (may be using a path pattern)
No we do not want to create the DiscoveredPackage in this case. |
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Implemented in #778 |
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
We should likely consider ABOUT files as "curations" for packages and they may likely override other scans/manifest data collection.
Here is a design:
Using ABOUT file for overries and curations
Say I have reviewed and curated the origin and license of this JAR
https://repo1.maven.org/maven2/log4j/log4j/1.2.13/log4j-1.2.13.jar
This is stored in an ABOUT file and license file this way, side by side:
The ABOUT file has this content:
These could live anywhere in the codebase inputs, typically in the FROM in a d2d pipeline for a start, but they could be in the TO or added as an extra input.
I would like that:
The text was updated successfully, but these errors were encountered: