Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance GetAsync to eliminate EF warnings #7203

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Enhance GetAsync to eliminate EF warnings #7203

merged 2 commits into from
Jan 14, 2021

Conversation

realLiangshiwei
Copy link
Member

Resolve #7188

https://docs.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore.diagnostics.coreeventid.firstwithoutorderbyandfilterwarning?view=efcore-5.0

A query uses First/FirstOrDefault operation without OrderBy and filter which may lead to unpredictable results.

@realLiangshiwei realLiangshiwei added this to the 4.2-preview milestone Jan 14, 2021
@maliming
Copy link
Member

When we include entity navigation properties, we need to order by, otherwise, there will be a warning.

@hikalkan hikalkan merged commit 3d8adea into dev Jan 14, 2021
@hikalkan hikalkan deleted the liangshiwei/efcore-patch-1 branch January 14, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliming maliming maliming approved these changes

@hikalkan hikalkan Awaiting requested review from hikalkan

Assignees
No one assigned
Labels
abp-framework
Projects
None yet
Milestone
4.2-preview
Development

Successfully merging this pull request may close these issues.

Remove EF warning logs 'The query uses a row limiting operator'
3 participants
@realLiangshiwei @maliming @hikalkan