-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding compatibility with whisper large-v3 #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joseporiolayats for the PR.
I think the large
ggml model is already the large-v3
whisper model, so there is no large-v3
in whisper.cpp
, instead we can change that constant to large-v2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats a good one
Hey @abdeladim-s missed the opportunity to thank you for this package!!! I made another commit in oder to add all the available models in the hf repo, including the quantized ones. Hope this all goes well :) |
Yeah, thanks @Govind-S-B for pointing that out, |
Hey @joseporiolayats, Everything seems perfect. |
Just changed a line so that it accepts large-v3 models, it wasn't even downloading them.