Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding compatibility with whisper large-v3 #32

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

joseporiolayats
Copy link
Contributor

Just changed a line so that it accepts large-v3 models, it wasn't even downloading them.

Copy link
Owner

@absadiki absadiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joseporiolayats for the PR.
I think the large ggml model is already the large-v3 whisper model, so there is no large-v3 in whisper.cpp, instead we can change that constant to large-v2 ?

@Govind-S-B
Copy link

Govind-S-B commented Feb 9, 2024

lol its weird that i was going to make a PR for this just now

Also yes large is now large-v3 and large v2 need to be added , but from how the models are downloaded directly based on the name you pass in return f"{MODELS_BASE_URL}/{MODELS_PREFIX_URL}-{model_name}.bin" , large-v3 should be the thing as there is no large.bin
image
image

Can we have large as an alias as well for large-v3 ? If this PR doesnt reolve it ill make a PR later ig

Copy link

@Govind-S-B Govind-S-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats a good one

@joseporiolayats
Copy link
Contributor Author

Hey @abdeladim-s missed the opportunity to thank you for this package!!!

I made another commit in oder to add all the available models in the hf repo, including the quantized ones.

Hope this all goes well :)

@absadiki
Copy link
Owner

absadiki commented Feb 9, 2024

lol its weird that i was going to make a PR for this just now

Also yes large is now large-v3 and large v2 need to be added , but from how the models are downloaded directly based on the name you pass in return f"{MODELS_BASE_URL}/{MODELS_PREFIX_URL}-{model_name}.bin" , large-v3 should be the thing as there is no large.bin image image

Can we have large as an alias as well for large-v3 ? If this PR doesnt reolve it ill make a PR later ig

Yeah, thanks @Govind-S-B for pointing that out, large-v3 is actually the right file and not large .
For now, I can see @joseporiolayats took care of everything. As for the alias, if you have an idea feel free to send a PR any time.

@absadiki
Copy link
Owner

absadiki commented Feb 9, 2024

Hey @abdeladim-s missed the opportunity to thank you for this package!!!

I made another commit in oder to add all the available models in the hf repo, including the quantized ones.

Hope this all goes well :)

Hey @joseporiolayats, Everything seems perfect.
Thank you as well for the awesome contribution :)

@absadiki absadiki merged commit 00eaadf into absadiki:main Feb 9, 2024
9 of 10 checks passed
@joseporiolayats joseporiolayats deleted the whisper-large-v3 branch February 10, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants