Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better unicode handling for whisper_full_get_segment_text #93

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

andrewchen5678
Copy link
Contributor

@andrewchen5678 andrewchen5678 commented Dec 29, 2024

Passing the raw byte array back and use python to decode utf-8 instead to replace invalid unicode characters. Solves #92

@absadiki
Copy link
Owner

Looks Great!
Thanks a lot @andrewchen5678 for the contribution :)

@absadiki absadiki merged commit 9441061 into absadiki:main Dec 29, 2024
14 checks passed
@andrewchen5678 andrewchen5678 deleted the unicode-handling branch December 30, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants