Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tests for today's date #119

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Better tests for today's date #119

merged 2 commits into from
Mar 28, 2023

Conversation

aburrell
Copy link
Owner

@aburrell aburrell commented Mar 28, 2023

Description

Fixes a remaining part of #115 by ensuring a valid apex conversion takes place for today's date.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

import apexpy
import datetime as dt
import numpy as np

apex_out = apexpy.Apex(date=dt.datetime.utcnow(), refh=300)
np.isnan(apex_out.geo2apex(60, 15, 100)).any()

Results should be False

Test Configuration

  • Operating system: OS X Big Sur
  • Python version number: 3.9
  • Compiler with version number: gfortran 12.2.0
  • Relevant local setup details: N/A

Checklist

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to Changelog.rst, summarising the changes
  • Add yourself to AUTHORS.rst and .zenodo.json

Updated the next version number in the CHANGELOG.
Added another unit test for today's date that ensures a conversion to apex coordinates produces a value.
@aburrell aburrell merged commit e7ed1b3 into develop Mar 28, 2023
@aburrell aburrell deleted the better_today_apex_test branch March 28, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant