Ensure pickle files can be read by earlier versions of NVDA (nvaccess…

…#7105) Impacts both the add-ons state and the updater state files. Both are now written using pickle protocol 0 so that Python 2 version of NVDA can read them in case of downgrading. Re nvaccess#10224 (comment)
accessolutions · Sep 20, 2019 · 3561ba5 · 3561ba5
1 parent 0e4bb4a
commit 3561ba5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/source/addonHandler/__init__.py b/source/addonHandler/__init__.py
@@ -72,7 +72,7 @@ def saveState():
 	try:
 		# #9038: Python 3 requires binary format when working with pickles.
 		with open(statePath, "wb") as f:
-			pickle.dump(state, f)
+			pickle.dump(state, f, protocol=0)
 	except:
 		log.debugWarning("Error saving state", exc_info=True)
 

diff --git a/source/updateCheck.py b/source/updateCheck.py
@@ -744,7 +744,7 @@ def saveState():
 	try:
 		# #9038: Python 3 requires binary format when working with pickles.
 		with open(_stateFilename, "wb") as f:
-			pickle.dump(state, f)
+			pickle.dump(state, f, protocol=0)
 	except:
 		log.debugWarning("Error saving state", exc_info=True)