Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

PrincipalComponentAnalysis serialization error in v3.4.0 #398

Closed
AndreiArdelean1 opened this issue Jan 27, 2017 · 2 comments
Closed

PrincipalComponentAnalysis serialization error in v3.4.0 #398

AndreiArdelean1 opened this issue Jan 27, 2017 · 2 comments

Comments

@AndreiArdelean1
Copy link

AndreiArdelean1 commented Jan 27, 2017 •
edited
Loading

When trying to serialize a member of class PrincipalComponentAnalysis in Accord.Statistics version 3.4.0, I revive the error:

Type 'System.Threading.CancellationToken' in Assembly 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' is not marked as serializable.

The error is not present in version 3.3.0

Accord.IO.Serializer.Save(new Accord.Statistics.Analysis.PrincipalComponentAnalysis(), System.IO.Path.GetFullPath("a.txt"));
@AndreiArdelean1 AndreiArdelean1 changed the title PrincipalComponentAnalysis serialization error in 3.4.0 PrincipalComponentAnalysis serialization error in v3.4.0 Jan 27, 2017
@cesarsouza
Copy link
Member

Many thanks for reporting the issue! I will commit a fix in the following minutes.

cesarsouza added a commit that referenced this issue Jan 27, 2017
@cesarsouza
GH-398: PrincipalComponentAnalysis serialization error in v3.4.0
1f34143 
Fixing serialization of PCA, KPCA, LDA, KDA and other classes that contain a CancellationToken.
@cesarsouza
Copy link
Member

Fixed in 3.5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cesarsouza @AndreiArdelean1