Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): fix browser build for concerto-util #970

Merged
merged 4 commits into from
Dec 12, 2024
Merged

fix(utils): fix browser build for concerto-util #970

merged 4 commits into from
Dec 12, 2024

Conversation

sanketshevkar
Copy link
Member

Closes #

npm ci and npm run build executed successfully.
concerto-core now should use [email protected] now thus making the browser build stable

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@mttrbrts mttrbrts merged commit 85366be into accordproject:main Dec 12, 2024
11 checks passed
Mamatha1718 pushed a commit to Mamatha1718/concerto that referenced this pull request Feb 7, 2025
@sanketshevkar @mttrbrts @Mamatha1718
fix(utils): fix browser build for concerto-util (accordproject#970)
ffb1110 
* chore(actions): publish v3.20.1 to npm

Signed-off-by: GitHub <[email protected]>

* fix(utils): fix browser build for concerto-util

Signed-off-by: sanketshevkar <[email protected]>

* fix(utils): fix browser build for concerto-util

Signed-off-by: sanketshevkar <[email protected]>

* fix(utils): fix browser build for concerto-util

Signed-off-by: sanketshevkar <[email protected]>

---------

Signed-off-by: GitHub <[email protected]>
Signed-off-by: sanketshevkar <[email protected]>
Co-authored-by: mttrbrts <[email protected]>
Signed-off-by: Mamatha Bandi <[email protected]>
Mamatha1718 pushed a commit to Mamatha1718/concerto that referenced this pull request Feb 8, 2025
@sanketshevkar @mttrbrts @Mamatha1718
fix(utils): fix browser build for concerto-util (accordproject#970)
1c7f491 
* chore(actions): publish v3.20.1 to npm

Signed-off-by: GitHub <[email protected]>

* fix(utils): fix browser build for concerto-util

Signed-off-by: sanketshevkar <[email protected]>

* fix(utils): fix browser build for concerto-util

Signed-off-by: sanketshevkar <[email protected]>

* fix(utils): fix browser build for concerto-util

Signed-off-by: sanketshevkar <[email protected]>

---------

Signed-off-by: GitHub <[email protected]>
Signed-off-by: sanketshevkar <[email protected]>
Co-authored-by: mttrbrts <[email protected]>
Signed-off-by: Mamatha Bandi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketshevkar @mttrbrts