Skip to content

Commit

Permalink
docs: Use a non-SSH method of installing Gerrit commit hook
Browse files Browse the repository at this point in the history
Apparently, contributors in China cannot connect to the Gerrit SSH port.
Because of this, they cannot follow the How to Contribute directions for
installing the Gerrit commit hook.

This patch updates those instructions to use HTTPS instead of SSH for
installing the Gerrit commit hook, which should work for everyone.

Change-Id: Ibdb024aafcd601f740ae73d83c54f9659cc5a3a9
Reviewed-on: http://gerrit.cloudera.org:8080/11896
Reviewed-by: Alexey Serbin <[email protected]>
Reviewed-by: Grant Henke <[email protected]>
Tested-by: Grant Henke <[email protected]>
  • Loading branch information
mpercy committed Nov 7, 2018
1 parent ee817a8 commit ecdeac7
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions docs/contributing.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,13 @@ git remote add gerrit ssh://<username>@gerrit.cloudera.org:29418/kudu
----

. Run the following command to install the
Gerrit `commit-msg` hook. Use the following command, replacing `<username>` with your
Github username.
Gerrit `commit-msg` hook. Use the following command:
+
----
gitdir=$(git rev-parse --git-dir); scp -p -P 29418 <username>@gerrit.cloudera.org:hooks/commit-msg ${gitdir}/hooks/
cd kudu
gitdir=$(git rev-parse --git-dir)
curl -LSsf https://gerrit.cloudera.org/tools/hooks/commit-msg -o ${gitdir}/hooks/commit-msg
chmod +x ${gitdir}/hooks/commit-msg
----

. Be sure you have set the Kudu repository to use `pull --rebase` by default. You
Expand Down

0 comments on commit ecdeac7

Please sign in to comment.