-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weaponselect - Fix case sensitivity when cycling throwables #10660
Merged
PabstMirror
merged 3 commits into
acemod:master
from
bagigi-arma:fix/case-sensitive-grenade-cycling
Jan 18, 2025
Merged
Weaponselect - Fix case sensitivity when cycling throwables #10660
PabstMirror
merged 3 commits into
acemod:master
from
bagigi-arma:fix/case-sensitive-grenade-cycling
Jan 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rautamiekka
suggested changes
Jan 14, 2025
Skill issue (on Unsung's side) |
LinkIsGrim
reviewed
Jan 14, 2025
LinkIsGrim
reviewed
Jan 14, 2025
Imo this isn't an optimal fix. A better fix would be to private _magazines = (getArray (_cfgThrow >> _x >> "magazines")) apply {_x call EFUNC(common,getConfigName)}; in preInit and nothing else needs changing. Case sensitivity is only done once at mission start, instead of everytime you cycle a grenade. |
Co-Authored-By: johnb432 <[email protected]>
PabstMirror
reviewed
Jan 14, 2025
PabstMirror
added
the
status/added-to-RC
Added after RC, need to manually add to changelog
label
Jan 15, 2025
PabstMirror
approved these changes
Jan 15, 2025
Co-Authored-By: johnb432 <[email protected]> Co-Authored-By: PabstMirror <[email protected]>
PabstMirror
approved these changes
Jan 18, 2025
I was going to suggest we move this to preStart and cache it once |
PabstMirror
removed
the
status/added-to-RC
Added after RC, need to manually add to changelog
label
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
It was encountered with grenades from the Unsung mod, the cause was that:
ace_weaponselect_GrenadesAll/Frag/NonFrag
atpreInit
by sifting through"CfgWeapons" >> "Throw"
.weaponselect/fnc_selectNextGrenade.sqf
however intersects theGrenadesAll
array withthrowables player
, which is generated fromCfgMagazines
names.CfgMagazines
andCfgWeapons
, likeuns_m18Purple
vsuns_m18purple
, causing them to be excluded from the grenade list and impossible to cycle to.