Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sass-embedded instead of sass for faster compilation #322

Closed
wants to merge 2 commits into from

Conversation

eoinkelly
Copy link
Contributor

We only compile Sass on platforms which sass-embedded supports and
faster asset builds is always nice, especially in development.

https://www.npmjs.com/package/sass-embedded
This package is an alternative to the sass package. It supports the same
JS API as sass and is maintained by the same team, but where the sass
package is pure JavaScript, sass-embedded is instead a JavaScript
wrapper around a native Dart executable. This means sass-embedded will
generally be much faster especially for large Sass compilations, but it
can only be installed on the platforms that Dart supports: Windows, Mac
OS, and Linux.

Closes issue #321

We only compile Sass on platforms which sass-embedded supports and
faster asset builds is always nice, especially in development.

> https://www.npmjs.com/package/sass-embedded
> This package is an alternative to the sass package. It supports the same
> JS API as sass and is maintained by the same team, but where the sass
> package is pure JavaScript, sass-embedded is instead a JavaScript
> wrapper around a native Dart executable. This means sass-embedded will
> generally be much faster especially for large Sass compilations, but it
> can only be installed on the platforms that Dart supports: Windows, Mac
> OS, and Linux.
@eoinkelly
Copy link
Contributor Author

CI failing because of issue #323

@eoinkelly eoinkelly marked this pull request as ready for review August 3, 2022 22:50
@eoinkelly eoinkelly requested review from a team and G-Rath August 3, 2022 22:50
@eoinkelly
Copy link
Contributor Author

Closing because it seems fiddlier than anticipated. Details in #321

@eoinkelly eoinkelly closed this Aug 4, 2022
@eoinkelly eoinkelly deleted the use-sass-embedded branch August 4, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants