Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image loading and add example image to prove it #324

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

eoinkelly
Copy link
Contributor

Closes issue #308.

I scaled down the suggested image in #308 to make it less disruptive on the page. While adding the example image I realised that image_pack_tag was broken by default so fixed that too.

@eoinkelly eoinkelly requested review from G-Rath and a team August 3, 2022 22:51
@eoinkelly eoinkelly marked this pull request as ready for review August 3, 2022 22:51
@eoinkelly
Copy link
Contributor Author

CI failing because of issue #323.

@eoinkelly eoinkelly merged commit ac8ba55 into main Aug 4, 2022
@eoinkelly eoinkelly deleted the issue-308-example-image branch August 4, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants