Videos #40
Merged
Videos #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bgarcia11
commented
Jan 26, 2025
bgarcia11
commented
- Added videos with carousel component
- Used dummy youtube link
- Circles change video
Closed
stormyy00
reviewed
Jan 27, 2025
src/components/resources/videos.tsx
Outdated
| import Carousel from "./carousel"; | ||
|
|
||
| const videos1 = [ | ||
| "https://www.youtube.com/embed/xsh4_9VX9jM?si=4dlhoadJtRFfugTH", |
| <div | ||
| key={i} | ||
| onClick={() => setCurr(i)} | ||
| className={`h-3 w-3 rounded-full bg-ucr-yellow transition-all ${curr === i ? "p-1" : "bg-opacity-50"} `} |
There was a problem hiding this comment.
cursor-pointer so we can see the mouse
src/components/resources/videos.tsx
Outdated
| <div className="pb-20"> | ||
| <p className="mb-3">3Blue1Brown Deep Learning Series</p> | ||
| <Carousel videos={videos1} /> | ||
| </div> |
There was a problem hiding this comment.
you could easily use a map here since the code used repeated like 4x
stormyy00
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.