Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the footer image #20

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Added the footer image #20

wants to merge 4 commits into from

Conversation

AltonQian
Copy link
Collaborator

@AltonQian AltonQian commented Jan 13, 2025 •
edited
Loading

image

@AltonQian AltonQian self-assigned this Jan 13, 2025
JohnZ9865
JohnZ9865 requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@JohnZ9865 JohnZ9865 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original image is bugged. Remove the footerdesign.svg. Try putting this image instead, see if this works. You might need to crop the image for it to work.
FooterImage

@sunbrandon
Copy link
Collaborator

Use link tags for email discord and instagram

@JohnZ9865
Copy link
Contributor

is it possible to make it shorter
image

@JohnZ9865
Copy link
Contributor

image

@charleenschen charleenschen linked an issue Jan 29, 2025 that may be closed by this pull request
Footer Component #5
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZ9865 JohnZ9865 JohnZ9865 requested changes

@charleenschen charleenschen Awaiting requested review from charleenschen

@sunbrandon sunbrandon Awaiting requested review from sunbrandon

Requested changes must be addressed to merge this pull request.

Assignees

@AltonQian AltonQian

Labels
Changes Requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer Component
3 participants
@AltonQian @sunbrandon @JohnZ9865