Join Landing Component #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JohnZ9865
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Text not centered within the box, box also too wide.
See Figma here: https://www.figma.com/design/8ZeXQoA0o5ZHfCO8KL5A0v/Fencing-Club-Website-(Copy)?node-id=0-1&p=f
… Motunrayo/joinLanding
|
|
JohnZ9865
reviewed
Jan 22, 2025
src/components/JoinLanding.tsx
Outdated
| </div> | ||
| </div> | ||
|
|
||
| <div className="h-44 w-4/5 rounded-lg bg-gray-400"></div> |
There was a problem hiding this comment.
Try to avoid hardcoding the h-44 if possible.
Suggested change
| <div className="h-44 w-4/5 rounded-lg bg-gray-400"></div> | |
| <div className="h-44 w-4/5 rounded-lg bg-gray-400"></div> |
JohnZ9865
requested changes
Jan 22, 2025
|
Lgtm, I just added a placeholder for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.