recloned and added code #30
Conversation
|
Looking good for now! There are 1-2 things to fix (which we haven't covered yet), and will be one of the topics of our next meeting! |
|
|
src/components/about/ValueCard.tsx
Outdated
|
|
||
| return ( | ||
| <div className={containerClasses}> | ||
| <h2 className={titleClasses}>{title}</h2> |
src/components/about/ValueCard.tsx
Outdated
| "text-3xl text-leap-dark-green mb-6 text-center font-bold tracking-widest"; | ||
|
|
||
| const boxClasses = | ||
| "bg-leap-mid-green p-6 shadow-[0_4px_6px_rgba(0.9,1.9,0.9,1.9)] max-w-[300px] text-center text-white text-base leading-relaxed relative tracking-widest"; |
There was a problem hiding this comment.
look at this component for how to use tailwind box shadow: https://github.com/acm-ucr/leap-website/blob/dev/src/components/home/Value_Box.tsx
don't use max-w, or leading(regular w- is fine), text-base is also active by default so no need to have this part
src/components/about/ValueCard.tsx
Outdated
| const containerClasses = "flex flex-col items-center my-8"; | ||
|
|
||
| const titleClasses = | ||
| "text-3xl text-leap-dark-green mb-6 text-center font-bold tracking-widest"; |
There was a problem hiding this comment.
tracking is unnecessary here
src/components/about/ValueCard.tsx
Outdated
|
|
||
| const ValueCard: React.FC<ValueCardProps> = ({ title, text }) => { | ||
| // Assign class names to variables for readability and maintainability | ||
| const containerClasses = "flex flex-col items-center my-8"; |
There was a problem hiding this comment.
move these from being declared separately to being inline to be consistent with other components.
|
Hello, I have pushed some new fixes for addressing the shadow, inline elements, and removing tracking when necessary. Please let me know what you think. this is how the output looks now: |
I created the card component and tried to closely match the design in the issue. The text is dynamic, making the component reusable for multiple purposes.
Please review the implementation and let me know if there are any changes or improvements you'd like to see!
Attached is my output and the expected output:
fixes #11