Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctraino/headercomponent #48

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Ctraino/headercomponent #48

merged 4 commits into from
Feb 5, 2025

Conversation

ctraino
Copy link
Collaborator

@ctraino ctraino commented Jan 21, 2025

Fixed header, made it take inputs, background is transparent.
Screenshot 2025-01-28 at 7 05 32 PM

…age. still need to figure out how to input background
@ctraino ctraino self-assigned this Jan 21, 2025
@ctraino ctraino added the question Further information is requested label Jan 21, 2025
@Kevinloritsch
Copy link
Contributor

Have you had a chance to go through the changes we talked about during the meeting?

…nts and board page run off of one header component with props
@ctraino ctraino added ready for review Issue Finished and removed question Further information is requested labels Jan 29, 2025
@Kevinloritsch
Copy link
Contributor

Almost done! The last thing that's left is to resolve conflicts (you just need to make it so it calls your code and the other events below it)
after this time for the next issue! lmk if you need help w the merge conflict

Copy link
Contributor

@Kevinloritsch Kevinloritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Kevinloritsch Kevinloritsch merged commit 3215ec3 into dev Feb 5, 2025
5 checks passed
@Kevinloritsch Kevinloritsch deleted the ctraino/headercomponent branch February 5, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Issue Finished
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants