Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavBar Mobile #60

Merged
merged 3 commits into from
Nov 16, 2024
Merged

NavBar Mobile #60

merged 3 commits into from
Nov 16, 2024

Conversation

Howardwheeler
Copy link
Collaborator

image

@Howardwheeler Howardwheeler self-assigned this Nov 4, 2024
@Howardwheeler
Copy link
Collaborator Author

Howardwheeler commented Nov 7, 2024 •
edited
Loading

actual good design maybe ? lmk if u want me to add or remove stuff, I made the background stars like how it is for the rest of the page cuz I wasn't sure which background was best (also lmk if I should get rid of the bars under each title)
image

stormyy00
stormyy00 reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@stormyy00 stormyy00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the bars should only show if the user is on that page.
  • for the background i think you should try solid bg-black

@Howardwheeler
Copy link
Collaborator Author

hows this
image

@stormyy00 stormyy00 merged commit baa7a68 into dev Nov 16, 2024
5 checks passed
@Howardwheeler Howardwheeler linked an issue Nov 17, 2024 that may be closed by this pull request
Navigation mobile #44
Closed
@stormyy00 stormyy00 deleted the Howardwheeler/mobile-nav branch December 22, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormyy00 stormyy00 stormyy00 approved these changes

Assignees

@Howardwheeler Howardwheeler

Labels
Ready to Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigation mobile
2 participants
@Howardwheeler @stormyy00