Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work #63

Merged
merged 5 commits into from
Feb 5, 2025
Merged

work #63

merged 5 commits into from
Feb 5, 2025

Conversation

Shadow709
Copy link
Collaborator

No description provided.

@Shadow709 Shadow709 self-assigned this Jan 31, 2025
@Shadow709 Shadow709 linked an issue Jan 31, 2025 that may be closed by this pull request
@Shadow709 Shadow709 added the in progress Currently WIP label Jan 31, 2025
@Shadow709
Copy link
Collaborator Author

image

@Shadow709 Shadow709 added ready for review Issue is completed and removed in progress Currently WIP labels Feb 1, 2025
Copy link
Contributor

@mailynnguyen mailynnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ncie job!

on really small screens, the spacing is still a little inconsistent tho. for example, with the iPhone SE:
image

Might have to make the text-size even smaller. I suggest giving the Button component padding size in percentages as well, instead of integer values. This might make the padding look a little nicer, and give the button a little more horizontal padding on small screens ^

@mailynnguyen mailynnguyen added requested changes Requested changes and removed ready for review Issue is completed labels Feb 2, 2025
@Shadow709
Copy link
Collaborator Author

should be good now
image

Copy link
Contributor

@mailynnguyen mailynnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, ty

@mailynnguyen mailynnguyen merged commit 45be684 into dev Feb 5, 2025
5 checks passed
@mailynnguyen mailynnguyen deleted the Amir/sparring2 branch February 5, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requested changes Requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MR - Home - Sparring Gear Section
3 participants