Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MR for MemberSignUp #71

Merged
merged 11 commits into from
Feb 5, 2025
Merged

MR for MemberSignUp #71

merged 11 commits into from
Feb 5, 2025

Conversation

HaokunYang123
Copy link
Collaborator

No description provided.

@HaokunYang123 HaokunYang123 self-assigned this Feb 3, 2025
@HaokunYang123 HaokunYang123 added the help wanted Extra attention is needed label Feb 3, 2025
@HaokunYang123
Copy link
Collaborator Author

image

@HaokunYang123
Copy link
Collaborator Author

im not sure if I did this correctly, there is overflow to the right

@HaokunYang123 HaokunYang123 linked an issue Feb 3, 2025 that may be closed by this pull request
MR - Home - Member Signup #61
Closed
mailynnguyen
mailynnguyen reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@mailynnguyen mailynnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Talked about Button padding already, another note, can you make the text a little smaller on some screen sizes, can be a little big:

image

@mailynnguyen mailynnguyen added the reviewed Has been reviewed label Feb 5, 2025
@HaokunYang123 HaokunYang123 added ready for review Issue is completed and removed help wanted Extra attention is needed labels Feb 5, 2025
mailynnguyen
mailynnguyen approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@mailynnguyen mailynnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job! ty 👍

@mailynnguyen mailynnguyen merged commit 85ab18c into dev Feb 5, 2025
5 checks passed
@mailynnguyen mailynnguyen deleted the HaokunYang123/MemberSignupMR branch February 5, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mailynnguyen mailynnguyen mailynnguyen approved these changes

Assignees

@HaokunYang123 HaokunYang123

Labels
ready for review Issue is completed reviewed Has been reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MR - Home - Member Signup
2 participants
@HaokunYang123 @mailynnguyen