All inkl kasserver dns script #1341

phlegx · 2018-03-09T15:40:05Z

Added my script for German provider All-inkl. It all works fine. However I cannot support yet the Domains with double endings like co.uk since my provider does not offer to get all root zones, as you suggested here: https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide

In case I just missed it, If anyone finds a way to get all root zones here: http://kasapi.kasserver.com/dokumentation/phpdoc/packages/API%20Funktionen.html just let me know and I add.

Let me know what you think Neil, and in best case lets just merge it right away! ;-)

thanks
Martin

Neilpang · 2018-03-10T01:10:35Z

Please update the docs:
https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide#9-update-the-docs-to-include-your-dns-api-and-usage

Neilpang · 2018-03-10T01:14:06Z

Is this api free?
How can I register account there to test ?

Thanks.

Neilpang · 2018-03-10T01:20:08Z

There is a function get_domains (array $ parameter) in the doc.
http://kasapi.kasserver.com/dokumentation/phpdoc/packages/API%20Funktionen.html

Neilpang · 2018-03-10T01:20:30Z

please fix the CI errors.

Neilpang · 2018-03-10T01:21:05Z

dnsapi/dns_kas.sh

+  _info "Adding or Updating $_full_domain DNS TXT entry on All-inkl/Kasserver"
+
+  _check_and_save
+  _get_zone "$_full_domain"


check the return value of these function calls.

@Neilpang you mean all of the functions need a return value (i.e. successful: return 0), or?

Neilpang · 2018-03-10T01:21:51Z

dnsapi/dns_kas.sh

+    params="$params&var5=zone_host"
+    params="$params&wert5=$_zone"
+  else # Update the existing record
+    _info "Updating existing TXT DNS record"


Never use updating, just adding.
#1261

Neilpang · 2018-03-10T01:22:39Z

dnsapi/dns_kas.sh

+  response="$(_get "$KAS_Api$params")"
+  _debug2 "response" "$response"
+
+  _record_id="$(echo "$response" | grep -A 4  "$_record_name" | grep "record_id" | cut -f2 -d">" | xargs)"


do not use grep -A and xargs

@Neilpang I think without using grep -A I can not do it actually. To me this seems to be the only most possible sane solution here, since what I get back is some HTML chunk with some plaintext array at the end, see example: https://gist.github.com/anonymous/eec9b149ab4b5ab8c30541a15e587d80

They also offer a WSDL https://kasapi.kasserver.com/dokumentation/?open=quellcode endpoint that can be accessed via SOAP and I think there I would get XML back, but I have no clue how to do this without using curl actually.

If you have an idea on how to solve this, let me know. thanks!

no, we have removed a lot of grep -A before.
show me your $response, and what you want to grep.

Hi @Neilpang see the example gist above. We need to grep for the record name (in this case _acme-challenge.test51 and then get out the appropriate record_id) I post the example here again:

.... <td align='right'> 10 <input name='var10' size='25' value=''> </td> <td> <input name='wert10' size='25' value=''> </td> </tr> <tr> <th colspan="2"> <a target="_blank" href="/dokumentation/?open=quellcode"> Beispiel Quellcode ansehen </a> </th> </tr> <tr> <th colspan="2" align="right"> Felder: <input size="2" name="anz_var" value="10" /> <input type="submit" /> </th> </tr> </table> </form> </div> <div style="float:left;"> <div class="erfolg"> <b>ReturnString: </b>TRUE</br> <b>ReturnInfo: </b><pre>Array ( [0] => Array ( [record_zone] => example.com [record_name] => [record_type] => NS [record_data] => ns6.kasserver.com. [record_aux] => 0 [record_id] => 0 [record_changeable] => N ) [1] => Array ( [record_zone] => example.com [record_name] => * [record_type] => A [record_data] => 85.13.yyy.xx [record_aux] => 0 [record_id] => 0 [record_changeable] => N ) [2] => Array ( [record_zone] => example.com [record_name] => _acme-challenge.test51 [record_type] => TXT [record_data] => jU6yvYv2Y4rHk2uFNwjxH1gcHmU7DRp4wvjoR6TEfgI [record_aux] => 0 [record_id] => 36986630 [record_changeable] => Y ) )

@Neilpang have you had already a chance to have a look at it? thanks!

@guptamp, @Neilpang has a few requirements that I should need to add to this as you can see in this Thread. I'm waiting for the suggestions he has for parsing this "HTML" file properly and according to the acme.sh rules.

However my implementation is already working and you could in the meanwhile just use my fork: https://github.com/phlegx/acme.sh I'm using it already in production and I will try to keep it up to date should it fail at some point.

Thanks @Neilpang! Also bit busy these days and need to see if I can have a look at this again in the next days. @dojo90 fyi! If you like and have time feel free to send me pull request!

Actually I'm confused. As you (@Neilpang) write here

do not use grep -A and xargs
#1341 (comment)

you give us a solution which uses grep 🤔

So I think we can use the actual implementation (https://github.com/phlegx/acme.sh/blob/all-inkl-kasserver-dns-script/dnsapi/dns_kas.sh#L153) ?

@dojo90

I mean don't use -A option with grep.

you can use simple grep command.

…ctive with that.

Ducksoul · 2018-12-11T20:55:30Z

push

I'd like to see this script in the production version. Unfortunately I'm not able to help concerning the points @Neilpang stated in his previous comments.

King3R · 2019-01-25T09:02:48Z

@phlegx Can you allow creating issues on your fork https://github.com/phlegx/acme.sh?

phlegx · 2019-01-25T09:05:32Z

@King3R done!

phlegx · 2019-01-25T09:40:39Z

I'm also open for fixes and pull requests btw, to finally get this merged in the original project :-)

King3R · 2019-01-25T10:59:26Z

I also hope that the PR will be merged with the original project. I can't help you because of my insufficient programming knowledge. :-(

Neilpang · 2019-01-25T13:23:50Z

@phlegx please resolve the conflicts first.

support to delete multiple entries

…ns-script

Neilpang · 2019-11-30T11:47:52Z

please fix CI errors first.
And follow this guide:
https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide

…ns-script

Marco4223 · 2019-12-21T21:38:31Z

Hi Neilpang,
when can we expect this feaure in prod? I'm interesst to use this with my pfsense.
If you need tester orsome test accounmts feel free to conatct me.
Cheers and merry christmas
Marco

Neilpang · 2019-12-23T14:35:01Z

dnsapi/dns_kas.sh

+# TODO Get a list of all possible root zones and compare (Currently not possible via provider)
+# See: https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide
+_get_zone() {
+  _zone=$(echo "$1" | rev | cut -d . -f1-2 | rev).


can you please not use rev ?

@Neilpang:

@Marco4223 was fixing a few more things (thank you very much Marco) and also he replaced the rev. For some reason the build is still failing. Could you please have a look and tell us what the issues still is since with this error Travis throws it is not clear to us what is missing. Thanks!

Maybe the empty lines with spaces?

remove "rev" command fix "Error removing txt for domain:_acme-challenge.foo"

only bash needed

sorry for this commit. ;) Fix NewBeMistakes

This reverts commit 99c47dd.

tested and works now

…-record-name Update dns_kas.sh

fixing 4 Travis style

…-record-name Update dns_kas.sh

Removing spaces in empty lines

…-record-name delete spaces in empty lines

Marco4223 · 2020-01-17T08:07:15Z

Hi Neilpang,
just for your info:
I have this script running on Pfsense an two Synology NAS systems.
Do you need an account for testing?
If yes just ping me.
Cheers
Marco

Neilpang · 2020-01-22T14:33:45Z

dnsapi/dns_kas.sh

+  params="$params&var5=zone_host"
+  params="$params&wert5=$_zone"
+  _debug2 "Wait for 10 seconds by default before calling KAS API."
+  sleep 10


please use our _sleep() function instead.

Neilpang · 2020-01-22T14:37:15Z

sorry, but we have a dev guide, please read and check it https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide

We need you to update your usage to the wiki and create a issue for future bug reporting.

Marco4223 · 2020-01-22T16:56:54Z

Hi Nail, Updated. Cheers Marco

…

Am 22.01.2020 um 15:37 schrieb neil ***@***.***>: sorry, but we have a dev guide, please read and check it https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide We need you to update your usage to the wiki and create a issue for future bug reporting. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

sleep 10 to _sleep 10

…-record-name Update dns_kas.sh

Marco4223 · 2020-02-10T09:34:06Z

Hi Nail,
everything fine now?
Cheers
MarcO

Neilpang · 2020-02-10T14:29:12Z

resolve the conflicts first, please.

Marco4223 · 2020-02-10T18:38:54Z

Sorry, may be I’m blind.
Where are conflicts?

phlegx added 2 commits March 9, 2018 16:29

Add All-inkl kasserver script.

861df49

Add own github repository URL.

32d7bd5

Neilpang reviewed Mar 10, 2018

View reviewed changes

phlegx force-pushed the all-inkl-kasserver-dns-script branch from 5e821ce to 32d7bd5 Compare March 16, 2018 13:42

phlegx added 8 commits March 16, 2018 14:49

Merge branch 'dev' into all-inkl-kasserver-dns-script

8c634d8

Update dnsapi Readme.

cbf0cea

Only create entry. Remove update.

e431df0

Fix return values of some functions.

11bfb1e

Rename full_domain and txt_value variables.

26b5180

remove debug output

cb4a2cf

Merge with latest dev branch.

c34aadf

Add default delay for the calls to KAS api since they are very restri…

68f66ca

…ctive with that.

fraenki mentioned this pull request Jan 28, 2019

security/acme-client: [Request] Support for All-Inkl.com ACME V2 request opnsense/plugins#1130

Closed

phlegx mentioned this pull request May 3, 2019

dns_kas.sh: Error removing txt for domain:_acme-challenge.foo phlegx/acme.sh#2

Open

djonasdev and others added 4 commits June 5, 2019 11:38

support to delete multiple entries

1ef7fd3

Merge pull request #3 from dojo90/all-inkl-kasserver-dns-script

16bfb17

support to delete multiple entries

Merge with Neilpang dev repo.

e22c5ea

Replace grep -A.

ec1f984

phlegx added 3 commits November 29, 2019 22:27

Merge remote-tracking branch 'upstream/dev' into all-inkl-kasserver-d…

d87e507

…ns-script

Fix a few snytax issues

c641b61

Remove obsolete blank.

953a9b1

phlegx added 2 commits December 12, 2019 16:23

Change the loop for sh.

3ccac62

Merge remote-tracking branch 'upstream/dev' into all-inkl-kasserver-d…

239d534

…ns-script

Neilpang reviewed Dec 23, 2019

View reviewed changes

Marco4223 and others added 10 commits December 28, 2019 11:58

Update dns_kas.sh

594b83e

remove "rev" command fix "Error removing txt for domain:_acme-challenge.foo"

Update dns_kas.sh

99c47dd

only bash needed

Update dns_kas.sh

a138425

sorry for this commit. ;) Fix NewBeMistakes

Revert "Update dns_kas.sh"

2214507

This reverts commit 99c47dd.

Update dns_kas.sh

8dd1df7

tested and works now

Merge pull request #4 from Marco4223/Fix-issues-and-reslolve-zone-and…

58cfc0d

…-record-name Update dns_kas.sh

Update dns_kas.sh

0246196

fixing 4 Travis style

Merge pull request #5 from Marco4223/Fix-issues-and-reslolve-zone-and…

96180e7

…-record-name Update dns_kas.sh

Update dns_kas.sh

431c53e

Removing spaces in empty lines

Merge pull request #6 from Marco4223/Fix-issues-and-reslolve-zone-and…

fb209cd

…-record-name delete spaces in empty lines

Neilpang reviewed Jan 22, 2020

View reviewed changes

Marco4223 and others added 2 commits January 23, 2020 19:20

Update dns_kas.sh

6613ae5

sleep 10 to _sleep 10

Merge pull request #7 from Marco4223/Fix-issues-and-reslolve-zone-and…

1c4b831

…-record-name Update dns_kas.sh

Merge branch 'dev' into all-inkl-kasserver-dns-script

7a30cb9

Neilpang merged commit 51fc853 into acmesh-official:dev Feb 11, 2020

All inkl kasserver dns script #1341

All inkl kasserver dns script #1341

Conversation

phlegx commented Mar 9, 2018 • edited Loading

Neilpang commented Mar 10, 2018

Neilpang commented Mar 10, 2018

Neilpang commented Mar 10, 2018

Neilpang commented Mar 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phlegx Mar 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phlegx Apr 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phlegx Nov 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ducksoul commented Dec 11, 2018

King3R commented Jan 25, 2019

phlegx commented Jan 25, 2019

phlegx commented Jan 25, 2019

King3R commented Jan 25, 2019

Neilpang commented Jan 25, 2019

Neilpang commented Nov 30, 2019

Marco4223 commented Dec 21, 2019

Choose a reason for hiding this comment

phlegx Jan 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Marco4223 commented Jan 17, 2020

Choose a reason for hiding this comment

Neilpang commented Jan 22, 2020

Marco4223 commented Jan 22, 2020 via email • edited Loading

Marco4223 commented Feb 10, 2020 • edited Loading

Neilpang commented Feb 10, 2020

Marco4223 commented Feb 10, 2020

phlegx commented Mar 9, 2018 •

edited

Loading

phlegx Mar 16, 2018 •

edited

Loading

phlegx Apr 27, 2018 •

edited

Loading

phlegx Nov 14, 2019 •

edited

Loading

phlegx Jan 15, 2020 •

edited

Loading

Marco4223 commented Jan 22, 2020 via email •

edited

Loading

Marco4223 commented Feb 10, 2020 •

edited

Loading