-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BookMyName API support #3208
Conversation
I added the secrets and enabled the actions on my repository, but it still fails... Not very clear where though... If you have any hint, I'm interested (the stuff works anyway). |
I checked your Actions log. it seems ok. But please read and finish the guide here: |
Hi Neil, Thanks ! I did miss the "create issue" step, it's fixed: #3209 About the doc, I was wondering if I have to add it now, or if/when the api is added to the dev code ? Thanks ! |
Yes, please add the doc now. please also rebase the latest dev code and run the actions now. |
Doc done. I tried the rebase (probably wrongly...), and the DNS action still fails :( |
|
This reverts commit d76fb56.
I don't get it, sorry. It works just fine locally, no idea why it doesn't on github. I redid all the secrets, still the same result... Running locally, with some bits "masked": Arnaud. |
can you please rerun the CI checks in your fork? |
Hello, checks rerun. DNS fails, apparently docker isn't happy. |
rebase the latest dev code and try again |
I'm not sure what I should do. My repo is already sync to the acme repo ? Date: Thu Jun 15 14:13:58 2023 +0200 And there's no new commits, so I don't have the possibility to merge (rebase ?) again... ? |
you must fix your ci tests: it's not passing now. |
Hello,
This adds BookMyName (https://www.bookmyname.com/) API support to acme.sh.
API documentation is here:
https://fr.faqs.bookmyname.com/frfaqs/dyndns
(in french, near the end)
It fixes #1740 .
Thanks,
Arnaud.