Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BookMyName API support #3208

Merged
merged 9 commits into from
Jul 10, 2023
Merged

Add BookMyName API support #3208

merged 9 commits into from
Jul 10, 2023

Conversation

alaunay
Copy link
Contributor

@alaunay alaunay commented Oct 5, 2020

Hello,

This adds BookMyName (https://www.bookmyname.com/) API support to acme.sh.

API documentation is here:
https://fr.faqs.bookmyname.com/frfaqs/dyndns
(in french, near the end)

It fixes #1740 .

Thanks,
Arnaud.

@alaunay
Copy link
Contributor Author

alaunay commented Oct 5, 2020

I added the secrets and enabled the actions on my repository, but it still fails... Not very clear where though... If you have any hint, I'm interested (the stuff works anyway).

@Neilpang
Copy link
Member

Neilpang commented Oct 6, 2020

I checked your Actions log. it seems ok.
The failure was caused by workflow errors. I'm fixing it. Just leave it.

But please read and finish the guide here:
https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Dev-Guide

@alaunay
Copy link
Contributor Author

alaunay commented Oct 6, 2020

Hi Neil,

Thanks ! I did miss the "create issue" step, it's fixed: #3209

About the doc, I was wondering if I have to add it now, or if/when the api is added to the dev code ?

Thanks !

@Neilpang
Copy link
Member

Neilpang commented Oct 9, 2020

About the doc, I was wondering if I have to add it now, or if/when the api is added to the dev code ?

Yes, please add the doc now.

please also rebase the latest dev code and run the actions now.

@alaunay
Copy link
Contributor Author

alaunay commented Oct 9, 2020

Doc done. I tried the rebase (probably wrongly...), and the DNS action still fails :(

@Neilpang
Copy link
Member

[Fri Oct  9 15:33:36 UTC 2020] ***:Verify error:DNS problem: NXDOMAIN looking up TXT for _acme-challenge.*** - check that a DNS record exists for this domain

@alaunay
Copy link
Contributor Author

alaunay commented Oct 10, 2020

I don't get it, sorry. It works just fine locally, no idea why it doesn't on github. I redid all the secrets, still the same result...

Running locally, with some bits "masked":

acme.log

Arnaud.

@Neilpang Neilpang deleted the branch acmesh-official:dev January 19, 2022 12:57
@Neilpang Neilpang closed this Jan 19, 2022
@Neilpang Neilpang reopened this Jan 19, 2022
@Neilpang
Copy link
Member

can you please rerun the CI checks in your fork?

@alaunay
Copy link
Contributor Author

alaunay commented Jun 15, 2023

Hello, checks rerun. DNS fails, apparently docker isn't happy.

@Neilpang
Copy link
Member

Neilpang commented Jul 8, 2023

rebase the latest dev code and try again

@alaunay
Copy link
Contributor Author

alaunay commented Jul 8, 2023

rebase the latest dev code and try again

I'm not sure what I should do. My repo is already sync to the acme repo ?

Date: Thu Jun 15 14:13:58 2023 +0200
Merge branch 'acmesh-official:master' into master

And there's no new commits, so I don't have the possibility to merge (rebase ?) again... ?

@Neilpang
Copy link
Member

Neilpang commented Jul 9, 2023

you must fix your ci tests:
https://github.com/cusae/acme.sh/actions/runs/5278904617

it's not passing now.

@Neilpang Neilpang merged commit 80ad62f into acmesh-official:dev Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants