Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode username, password, did, and totp for security #4202

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions deploy/synology_dsm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,10 @@ synology_dsm_deploy() {
_debug2 H1 "${_H1}"

# Now that we know the username & password are good, save them
_savedeployconf SYNO_Username "$SYNO_Username"
_savedeployconf SYNO_Password "$SYNO_Password"
_savedeployconf SYNO_Device_Name "$SYNO_Device_Name"
_savedeployconf SYNO_Device_ID "$SYNO_Device_ID"
_savedeployconf SYNO_Username "$SYNO_Username" "base64"
_savedeployconf SYNO_Password "$SYNO_Password" "base64"
_savedeployconf SYNO_DID "$SYNO_DID" "base64"
_savedeployconf SYNO_TOTP_SECRET "$SYNO_TOTP_SECRET" "base64"

_info "Getting certificates in Synology DSM"
response=$(_post "api=SYNO.Core.Certificate.CRT&method=list&version=1&_sid=$sid" "$_base_url/webapi/entry.cgi")
Expand Down